Skip to content

Conversation

@keyboardDrummer
Copy link
Member

@keyboardDrummer keyboardDrummer commented Jun 12, 2025

What was changed?

  • Process a few comments from https://github.com/dafny-lang/dafny/pull/6263f
  • Generate the schema and deserialization code, which produces a few changes because of existing changes in master (related to Function and Predicate), and a few changes coming from the above changes, related to the "traits" parameter.
  • Simplify serialization related generator code by no longer looking at fields and properties.

How has this been tested?

  • Changes covered by existing tests

By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.

Copy link
Contributor

@alex-chew alex-chew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me, although some CI failures suggest that nulls are still sneaking into TopLevelDeclWithMembers.Traits (e.g. https://github.com/dafny-lang/dafny/actions/runs/15606784506/job/43958075689?pr=6270#step:10:15)

@alex-chew alex-chew merged commit 788aab1 into dafny-lang:master Jun 14, 2025
22 checks passed
@keyboardDrummer keyboardDrummer deleted the syntaxSerializationRefactor branch June 15, 2025 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants