chore: Remove misplaced LL(1) resolvers and fix field location parsing #6289
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove two misplaced LL(1) resolvers that were flagged by Coco/R as unnecessary: - Remove IF(AcceptReferrersAndBacktick()) resolver in ConstAtomExpression - Remove IF(IsIdentifier(la.kind)) resolver in FieldLocationSuffix The resolvers don't actually resolve any parsing conflicts and can be safely removed. However, removing them requires restructuring field location parsing to handle backtick consumption correctly. Changes: - Replace IF(AcceptReferrersAndBacktick()) with direct backtick matching - Create FieldLocationBody production to handle backtick consumption properly - Ensure field location expressions work correctly with --referrers flag Impact: - Eliminates 2 'Misplaced resolver: no LL(1) conflict' warnings - Cleaner grammar with no unnecessary complexity - Identical parsing behavior (all tests pass) - Reduces build warnings from 2 to 0
MikaelMayer
reviewed
Jul 1, 2025
| "(" NameSegment<out e> ")" (. e = new UnaryOpExpr(x, UnaryOpExpr.Opcode.Assigned, e); .) | ||
| | IF(AcceptReferrersAndBacktick()) (. e = new ImplicitThisExpr(la); .) | ||
| FieldLocationSuffix<ref e> | ||
| | "`" (. if (!AcceptReferrers()) { |
There was a problem hiding this comment.
Neat. I would not have guess that this would work since "backtick name" is always a valid frame expression.
But it works great !
MikaelMayer
approved these changes
Jul 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes two misplaced LL(1) resolvers that were flagged by Coco/R as unnecessary and fixes the resulting field location parsing issue.
Problem
Coco/R was generating warnings for two misplaced resolvers:
These resolvers don't actually resolve any parsing conflicts and add unnecessary complexity.
Solution
Removed Misplaced Resolvers:
IF(AcceptReferrersAndBacktick())inConstAtomExpression(line 3767)IF(IsIdentifier(la.kind))inFieldLocationSuffix(line 4512)Fixed Field Location Parsing:
Removing the resolvers required restructuring field location parsing to handle backtick consumption correctly:
FieldLocationBodyproduction to separate backtick consumption logic,obj`field`) work correctlyImpact
--referrersflag functionality maintainedTesting
Type of Change
This is a pure maintenance change that improves code quality and eliminates some build warnings.