Extract code into separate methods in ExpressionTranslator, and extract BinaryExpr translation code into separate file #6301
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Happy to resolve any merge conflicts that resolve from this move. |
keyboardDrummer
requested review from
robin-aws
and removed request for
MikaelMayer
robin-aws
approved these changes
Jul 9, 2025
There was a problem hiding this comment.
More consistent file names with the rest of the package would be BoogieGenerator.Expressions.Binary.cs and BoogieGenerator.Expressions.MultisetDisplay.cs.
(I don't have a strong opinion about the idiom, just pointing it out)
There was a problem hiding this comment.
Thanks, I'll address it in a follow-up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed?
How has this been tested?
By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.