Fix test expectations for PR #3324 (clean implementation) #6302
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…messages - Update position format from (line,col) to (line:col-line:col) across all test files - Change error messages from 'might not hold' to 'could not be proved' - Update all related error message patterns (decreases, maintenance, etc.) - Ensure consistency with 'proved' vs 'proven' and lowercase error messages - Remove trailing periods from error messages as per PR requirements This addresses the test expectation issues in PR #3324 by applying the correct format changes to 1,076+ test and documentation files.
|
Closing this PR as it only updates test expectation files without the corresponding code changes that produce the new error messages. This approach is incorrect - both the source code changes and test expectations need to be updated together. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides a clean implementation of the test expectation fixes needed for PR #3324.
Changes Made
(line,col)to(line:col-line:col)across all test filesWhy This Approach
This is a clean implementation based on master that avoids the complex merge conflicts in the original PR #3324 branch. It applies only the essential test expectation fixes without the historical baggage.
Testing
This should resolve the CI failures by ensuring test expectations match the actual Dafny compiler output format.