You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Pulled the failing check logs with gh. The test failed while talking to the Elasticsearch test server after the lockfile upgraded elasticsearch to 9.x. CI runs against an Elasticsearch 8 server, and elasticsearch-py does not support cross-major client/server combinations. Constrained elasticsearch to >=8.10,<9 and regenerated the lockfile. Also ran uv run ruff check and uv run ruff format --check locally for libraries/dagster-elasticsearch, then pushed the fix.
Revisited the earlier fix: instead of constraining the client to <9, this restores the intended loose client pin (elasticsearch>=8.10,<11) and keeps the lockfile on the latest 9.x client. The failed CI log showed a connection reset during the first integration test rather than an API incompatibility, while the fixture already defaults to an Elasticsearch 9.1.3 container. I updated the test fixture to wait for client.info() to succeed before yielding the test URL, so the suite actually exercises ES 9 and avoids racing the container startup. Ran uv run ruff check and uv run ruff format --check locally, then pushed the update.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing