Dennis/polarsio partition metadata key#332
Open
dehume wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Fixes #330.
PolarsDeltaIOManagerwithmetadata={"partition_by": ...}regressed in0.27.12: writing a TimeWindowPartitionsDefinition-partitioned asset failed withCast error: Cannot cast string '2025' to value of Date32 type.PR #314 changed
get_predicateto emit aDATE '...'literal whenever the asset used a TimeWindowPartitionsDefinition:This assumes a time-window partition always maps to a Date column. But the column type is determined by the DataFrame being written, not the partition definition — a %Y yearly partition stored in a string year column produced year = DATE '2025', which deltalake can't cast against a string column.
How I Tested These Changes
PolarsDeltaIOManagerregression in0.27.12-partition_bymetadata key breaks withCannot cast string to Date32#330 (yearly %Y → string column). Verified it fails on the old logic with the exact reported error.Changelog
Ensure that an entry has been created in
CHANGELOG.mdoutlining additions, deletions, and/or modifications.See: keepachangelog.com