Skip to content

Update dbt workflow template#188

Open
benpankow wants to merge 4 commits into
mainfrom
benpankow/update-serverless-template-dbt
Open

Update dbt workflow template#188
benpankow wants to merge 4 commits into
mainfrom
benpankow/update-serverless-template-dbt

Conversation

@benpankow

@benpankow benpankow commented Jul 15, 2024

Copy link
Copy Markdown
Member

Summary

Updates the serverless dbt github actions workflow template to use the CI CLI.

Test Plan

Tested NUX flow locally using test GitHub app benpankow/jaffle_shop_duckdb_test#1

@benpankow

benpankow commented Jul 15, 2024

Copy link
Copy Markdown
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions

github-actions Bot commented Jul 15, 2024

Copy link
Copy Markdown

Your pull request is automatically being deployed to Dagster Cloud.

Location Status Link Updated
from_gh_action View in Cloud Jul 15, 2024 at 11:07 PM (UTC)

@github-actions

Copy link
Copy Markdown

Your pull request is automatically being deployed to Dagster Cloud.

Location Status Link Updated
from_gh_action Building... Jul 15, 2024 at 09:47 PM (UTC)

@benpankow benpankow requested a review from shalabhc July 15, 2024 22:10
@benpankow benpankow force-pushed the benpankow/update-serverless-template branch from deeb0ff to cf3aa2d Compare July 15, 2024 23:01
@benpankow benpankow force-pushed the benpankow/update-serverless-template-dbt branch from 5a7e09c to 631edc8 Compare July 15, 2024 23:01
@benpankow benpankow mentioned this pull request Jul 15, 2024

@shalabhc shalabhc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments in #187 apply here too.

Base automatically changed from benpankow/update-serverless-template to main July 29, 2024 22:57
# First ensure the correct Python version is installed
- name: Set up Python ${{ env.PYTHON_VERSION }} for target
id: custom-python-version
if: steps.pre-run.outputs.result == 'pex-deploy' && ${{ env.PYTHON_VERSION != '3.8' }}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The step ID is defined as prerun on line 32, but the condition references pre-run. This will cause the condition to fail. Update steps.pre-run.outputs.result to steps.prerun.outputs.result to match the step ID.

Spotted by Graphite Reviewer

Is this helpful? React 👍 or 👎 to let us know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants