Skip to content

Commit 8623b2f

Browse files
maint: remove unused SummarizeErrorWIthAIButton (#33014)
## Summary & Motivation The corresponding .cloud.tsx file is being deleted (see https://github.com/dagster-io/internal/pull/19557)
1 parent 1384678 commit 8623b2f

4 files changed

Lines changed: 2 additions & 32 deletions

File tree

js_modules/dagster-ui/packages/ui-core/src/app/PythonErrorInfo.tsx

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@ import {Box, Button, Icon} from '@dagster-io/ui-components';
22
import clsx from 'clsx';
33
import {ComponentProps, Fragment, forwardRef, useRef} from 'react';
44
import {PythonErrorInfoHeader} from 'shared/app/PythonErrorInfoHeader.oss';
5-
import {SummarizeErrorWithAIButton} from 'shared/runs/SummarizeErrorWithAIButton.oss';
65

76
import {showSharedToaster} from './DomUtils';
87
import {useCopyToClipboard} from './browser';
@@ -70,7 +69,6 @@ export const PythonErrorInfo = (props: IPythonErrorInfoProps) => {
7069
padding={{top: 16}}
7170
flex={{direction: 'row', gap: 4, alignItems: 'center', justifyContent: 'flex-end'}}
7271
>
73-
<SummarizeErrorWithAIButton error={props.error} />
7472
<CopyErrorButton
7573
copy={() => {
7674
const text = wrapperRef.current?.innerText || '';

js_modules/dagster-ui/packages/ui-core/src/runs/CellTruncationProvider.tsx

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,6 @@ interface Props {
3030
style: React.CSSProperties;
3131
onExpand?: () => void;
3232
forceExpandability?: boolean;
33-
buttons?: React.ReactNode;
3433
}
3534

3635
export const CellTruncationProvider = (props: Props) => {
@@ -79,7 +78,6 @@ export const CellTruncationProvider = (props: Props) => {
7978
<Button intent="primary" icon={<Icon name="unfold_more" />} onClick={onView}>
8079
View full message
8180
</Button>
82-
{props.buttons}
8381
</OverflowButtonContainer>
8482
{props.onExpand ? null : (
8583
<Dialog

js_modules/dagster-ui/packages/ui-core/src/runs/LogsRow.tsx

Lines changed: 2 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
import {Box, Button, Dialog, DialogBody, DialogFooter} from '@dagster-io/ui-components';
22
import * as React from 'react';
33
import {useMemo, useState} from 'react';
4-
import {SummarizeErrorWithAIButton} from 'shared/runs/SummarizeErrorWithAIButton.oss';
54

65
import {CellTruncationProvider} from './CellTruncationProvider';
76
import {
@@ -77,21 +76,9 @@ export const Structured = (props: StructuredProps) => {
7776
};
7877
}, [metadata, node]);
7978

80-
const buttons = useMemo(() => {
81-
if ('error' in node && node.error) {
82-
return <SummarizeErrorWithAIButton error={node.error} outlined={false} intent="primary" />;
83-
}
84-
return null;
85-
}, [node]);
86-
8779
return (
88-
<CellTruncationProvider style={style} onExpand={() => setExpanded(true)} buttons={buttons}>
89-
<StructuredMemoizedContent
90-
node={node}
91-
metadata={metadata}
92-
highlighted={highlighted}
93-
buttons={buttons}
94-
/>
80+
<CellTruncationProvider style={style} onExpand={() => setExpanded(true)}>
81+
<StructuredMemoizedContent node={node} metadata={metadata} highlighted={highlighted} />
9582
<Dialog
9683
title={title}
9784
isOpen={expanded}
@@ -255,7 +242,6 @@ interface StructuredMemoizedContentProps {
255242
node: LogsRowStructuredFragment;
256243
metadata: IRunMetadataDict;
257244
highlighted: boolean;
258-
buttons: React.ReactNode;
259245
}
260246

261247
const StructuredMemoizedContent = React.memo((props: StructuredMemoizedContentProps) => {

js_modules/dagster-ui/packages/ui-core/src/runs/SummarizeErrorWithAIButton.oss.tsx

Lines changed: 0 additions & 12 deletions
This file was deleted.

0 commit comments

Comments
 (0)