Skip to content

Commit 918b2c8

Browse files
hellendagDagster Devtools
authored andcommitted
[ui] Replace dagre GitHub fork with npm package + Yarn patch (#21613)
## Summary & Motivation The objective of this PR is to clean up the logspew that shows up in CI when we yarn install the dagre fork. This PR applies a patch to the `dagre` npm package to fix graph layout issues and add cluster padding configuration options, instead of the current approach of targeting a fork. ## Test Plan Verify with BK inspection that we're no longer spewing logs and warnings on the yarn install step. - Verify that graph layouts render without crashing when encountering null nodes - Test that the new cluster padding attributes are properly applied to graph layouts - Ensure existing graph functionality remains unchanged Internal-RevId: b1f467ecddad461ab4e576edfb4539f6696b2649
1 parent cbdff75 commit 918b2c8

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

js_modules/ui-core/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@
5858
"clsx": "^2.1.1",
5959
"codemirror": "^5.65.2",
6060
"cronstrue": "^2.51.0",
61-
"dagre": "dagster-io/dagre#0.8.5",
61+
"dagre": "patch:dagre@npm%3A0.8.5#~/.yarn/patches/dagre-npm-0.8.5-f3eb4059c5.patch",
6262
"date-fns": "^4.1.0",
6363
"dayjs": "^1.11.7",
6464
"deepmerge": "^4.2.2",

0 commit comments

Comments
 (0)