Skip to content

Commit beb8a84

Browse files
kang8Daniel Gibson
andauthored
Fix Helm schema URL referencing defunct kubernetesjsonschema.dev (#33135)
## Summary This PR fixes the Helm chart schema validation failure caused by the defunct `kubernetesjsonschema.dev` service. ### Problem When running Helm commands (e.g., `helm template`, `helm install`), users encounter the following error: ``` failing loading "https://kubernetesjsonschema.dev/v1.18.0/_definitions.json": HTTP request to https://kubernetesjsonschema.dev/v1.18.0/_definitions.json returned status 404 (Not Found) ``` The `kubernetesjsonschema.dev` service has been discontinued and no longer serves JSON schema files. ### Verification | URL | Status | |-----|--------| | https://kubernetesjsonschema.dev/v1.18.0/_definitions.json | ❌ 404 | | https://raw.githubusercontent.com/yannh/kubernetes-json-schema/master/v1.19.0/_definitions.json | ✅ 200 | ### Solution - Updated the schema URL from `kubernetesjsonschema.dev` to the actively maintained GitHub repository `yannh/kubernetes-json-schema` - Bumped the Kubernetes schema version from `1.18.0` to `1.19.0` (the earliest version available in the replacement repository) - Regenerated the `values.schema.json` files for both the main Dagster chart and the user-deployments subchart Fixes #33134 --------- Co-authored-by: Daniel Gibson <daniel@elementl.com>
1 parent ec5fdbb commit beb8a84

3 files changed

Lines changed: 43 additions & 45 deletions

File tree

helm/dagster/charts/dagster-user-deployments/values.schema.json

Lines changed: 18 additions & 18 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

helm/dagster/schema/schema/charts/utils/utils.py

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99

1010

1111
class SupportedKubernetes(str, Enum):
12-
V1_18 = "1.18.0"
12+
V1_19 = "1.19.0"
1313

1414

1515
class ConfigurableClass(PydanticBaseModel, extra="forbid"):
@@ -44,10 +44,8 @@ def schema_extra(schema, model):
4444
value["anyOf"].append({"type": "null"})
4545

4646

47-
def create_definition_ref(definition: str, version: str = SupportedKubernetes.V1_18.value) -> str:
48-
return (
49-
f"https://kubernetesjsonschema.dev/v{version}/_definitions.json#/definitions/{definition}"
50-
)
47+
def create_definition_ref(definition: str, version: str = SupportedKubernetes.V1_19.value) -> str:
48+
return f"https://raw.githubusercontent.com/yannh/kubernetes-json-schema/master/v{version}/_definitions.json#/definitions/{definition}"
5149

5250

5351
def create_json_schema_conditionals(

helm/dagster/values.schema.json

Lines changed: 22 additions & 22 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)