Skip to content

Commit e88f03f

Browse files
authored
[ui] Remove integrations marketplace feature (#33097)
## Summary & Motivation This PR removes the Integrations Marketplace feature from the Dagster UI. The change eliminates the marketplace navigation item, related UI components, and all supporting code for the feature. ## How I Tested These Changes Verified that the UI loads correctly without the marketplace feature and no feature flag in User Settings, and confirmed that the navigation no longer shows the Integrations link. ## Changelog [ui] Remove feature-flagged Integrations Marketplace, since individual code locations have docs available.
1 parent 8623b2f commit e88f03f

30 files changed

Lines changed: 3 additions & 1766 deletions

js_modules/dagster-ui/packages/ui-core/src/app/AppTopNav/AppTopNav.tsx

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -4,17 +4,15 @@ import {NavLink} from 'react-router-dom';
44
import {AppTopNavRightOfLogo} from 'shared/app/AppTopNav/AppTopNavRightOfLogo.oss';
55
import styled from 'styled-components';
66

7-
import {MarketplaceTopNavLink} from '../../integrations/MarketplaceTopNavLink';
8-
import {SearchTopNavItem} from '../../search/SearchTopNavItem';
9-
import {useFeatureFlags} from '../useFeatureFlags';
7+
import {useFullScreen} from './AppTopNavContext';
108
import {GhostDaggyWithTooltip} from './GhostDaggy';
119
import {
1210
reloadFnForWorkspace,
1311
useRepositoryLocationReload,
1412
} from '../../nav/useRepositoryLocationReload';
13+
import {SearchTopNavItem} from '../../search/SearchTopNavItem';
1514
import {LayoutContext} from '../LayoutProvider';
1615
import {ShortcutHandler} from '../ShortcutHandler';
17-
import {useFullScreen} from './AppTopNavContext';
1816

1917
interface Props {
2018
children?: React.ReactNode;
@@ -30,7 +28,6 @@ export const AppTopNav = ({children, allowGlobalReload = false}: Props) => {
3028
};
3129

3230
const AppTopNavImpl = ({children, allowGlobalReload = false}: Props) => {
33-
const {flagMarketplace} = useFeatureFlags();
3431
const {reloading, tryReload} = useRepositoryLocationReload({
3532
scope: 'workspace',
3633
reloadFn: reloadFnForWorkspace,
@@ -57,7 +54,6 @@ const AppTopNavImpl = ({children, allowGlobalReload = false}: Props) => {
5754
</ShortcutHandler>
5855
) : null}
5956
<SearchTopNavItem />
60-
{flagMarketplace ? <MarketplaceTopNavLink /> : null}
6157
{children}
6258
</Box>
6359
</AppTopNavContainer>

js_modules/dagster-ui/packages/ui-core/src/app/ContentRoot.tsx

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@ const SnapshotRoot = lazy(() => import('../snapshots/SnapshotRoot'));
2424
const GuessJobLocationRoot = lazy(() => import('../workspace/GuessJobLocationRoot'));
2525
const SettingsRoot = lazy(() => import('../settings/SettingsRoot'));
2626
const JobsRoot = lazy(() => import('../jobs/JobsRoot'));
27-
const IntegrationsRoot = lazy(() => import('../integrations/IntegrationsRoot'));
2827

2928
export const ContentRoot = memo(() => {
3029
const {pathname} = useLocation();
@@ -92,9 +91,6 @@ export const ContentRoot = memo(() => {
9291
<Route path="/deployment">
9392
<SettingsRoot />
9493
</Route>
95-
<Route path="/integrations">
96-
<IntegrationsRoot />
97-
</Route>
9894
<Route path="*" isNestingRoute>
9995
<FallthroughRoot />
10096
</Route>

js_modules/dagster-ui/packages/ui-core/src/app/FeatureFlags.oss.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@ export enum FeatureFlag {
55
flagDisableAutoLoadDefaults = 'flagDisableAutoLoadDefaults',
66
flagAssetNodeFacets = 'flagAssetNodeFacets',
77
flagUseNewObserveUIs = 'flagUseNewObserveUIs',
8-
flagMarketplace = 'flagMarketplace',
98
flagAssetGraphGroupsPerCodeLocation = 'flagAssetGraphGroupsPerCodeLocation',
109
flagNavigationUpdate = 'flagNavigationUpdate',
1110
flagAssetCatalogSidebar = 'flagAssetCatalogSidebar',

js_modules/dagster-ui/packages/ui-core/src/app/navigation/mainNavigationItems.tsx

Lines changed: 1 addition & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -284,7 +284,7 @@ const SettingsItem = () => {
284284
);
285285
};
286286

287-
export const getBottomGroups = ({featureFlags}: NavigationGroupConfig): NavigationGroup[] => {
287+
export const getBottomGroups = (_config: NavigationGroupConfig): NavigationGroup[] => {
288288
const searchGroup = [
289289
{
290290
key: 'search',
@@ -319,20 +319,5 @@ export const getBottomGroups = ({featureFlags}: NavigationGroupConfig): Navigati
319319
],
320320
};
321321

322-
if (featureFlags.flagMarketplace) {
323-
adminGroup.items.unshift({
324-
key: 'marketplace',
325-
label: 'Marketplace',
326-
element: (
327-
<NavItemWithLink
328-
icon={<Icon name="compute_kind" />}
329-
label="Integrations"
330-
href="/integrations"
331-
isActive={(_, currentLocation) => currentLocation.pathname.startsWith('/integrations')}
332-
/>
333-
),
334-
});
335-
}
336-
337322
return [...searchGroup, adminGroup];
338323
};

js_modules/dagster-ui/packages/ui-core/src/app/useVisibleFeatureFlagRows.oss.tsx

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -15,10 +15,6 @@ export const useVisibleFeatureFlagRows = (): FeatureFlagRow[] => [
1515
key: 'Display faceted asset graph nodes',
1616
flagType: FeatureFlag.flagAssetNodeFacets,
1717
},
18-
{
19-
key: 'Display integrations marketplace',
20-
flagType: FeatureFlag.flagMarketplace,
21-
},
2218
{
2319
key: 'Disable WebSockets',
2420
flagType: FeatureFlag.flagDisableWebsockets,

js_modules/dagster-ui/packages/ui-core/src/integrations/AddIntegrationButton.tsx

Lines changed: 0 additions & 78 deletions
This file was deleted.

js_modules/dagster-ui/packages/ui-core/src/integrations/IntegrationIcon.module.css

Lines changed: 0 additions & 19 deletions
This file was deleted.

js_modules/dagster-ui/packages/ui-core/src/integrations/IntegrationIcon.tsx

Lines changed: 0 additions & 43 deletions
This file was deleted.

js_modules/dagster-ui/packages/ui-core/src/integrations/IntegrationListPage.tsx

Lines changed: 0 additions & 110 deletions
This file was deleted.

js_modules/dagster-ui/packages/ui-core/src/integrations/IntegrationListRoot.tsx

Lines changed: 0 additions & 11 deletions
This file was deleted.

0 commit comments

Comments
 (0)