Skip to content

Conversation

@smackesey
Copy link
Collaborator

@smackesey smackesey commented Sep 16, 2024

Summary & Motivation

  • Add an asset, schedule, and sensor to the backcompat test repo
  • Add a test that queries the contents of the repo. Only runs for the latest release user code.

The motivation is to generally strengthen our backcompat tests and support upstack PRs that are doing heavy renaming in the external/snap layer.

How I Tested These Changes

BK

Changelog

NOCHANGELOG

  • NEW (added new feature or capability)
  • BUGFIX (fixed a bug)
  • DOCS (added or updated documentation)

Copy link
Collaborator Author

smackesey commented Sep 16, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @smackesey and the rest of your teammates on Graphite Graphite

@smackesey smackesey force-pushed the sean/backcompat/add-list-repo branch 4 times, most recently from 6f138a6 to 24082f2 Compare September 19, 2024 16:17
@smackesey smackesey changed the base branch from master to sean/backcompat/bump-earliest-user-code-version September 19, 2024 16:17
@smackesey smackesey force-pushed the sean/backcompat/bump-earliest-user-code-version branch 2 times, most recently from 41cd8d5 to 2da1f95 Compare September 19, 2024 18:51
@smackesey smackesey force-pushed the sean/backcompat/add-list-repo branch from 24082f2 to 1a21c40 Compare September 19, 2024 18:51
@smackesey smackesey force-pushed the sean/backcompat/bump-earliest-user-code-version branch from 2da1f95 to bd85532 Compare September 25, 2024 19:56
@smackesey smackesey force-pushed the sean/backcompat/add-list-repo branch 2 times, most recently from 0f7224e to 50b4bcd Compare September 25, 2024 20:24
@smackesey smackesey marked this pull request as ready for review September 26, 2024 17:40
Copy link
Member

@alangenfeld alangenfeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🫡

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: maybe more specific names for these files, i cant reason through what should go where with basic and legacy

@smackesey smackesey force-pushed the sean/backcompat/bump-earliest-user-code-version branch from bd85532 to c0d8c92 Compare September 27, 2024 11:50
@smackesey smackesey force-pushed the sean/backcompat/add-list-repo branch from 50b4bcd to ec4950f Compare September 27, 2024 11:51
@graphite-app graphite-app bot added the area: docs Related to documentation in general label Sep 27, 2024
@smackesey smackesey force-pushed the sean/backcompat/add-list-repo branch from ec4950f to 9d2e21f Compare September 27, 2024 12:12
@smackesey smackesey changed the base branch from sean/backcompat/bump-earliest-user-code-version to master September 27, 2024 12:13
@smackesey smackesey force-pushed the sean/backcompat/add-list-repo branch 2 times, most recently from f5af5f4 to a97482a Compare September 27, 2024 12:29
@smackesey smackesey force-pushed the sean/backcompat/add-list-repo branch from a97482a to e161e63 Compare September 27, 2024 13:13
@smackesey smackesey merged commit f09d795 into master Sep 27, 2024
@smackesey smackesey deleted the sean/backcompat/add-list-repo branch September 27, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: docs Related to documentation in general

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants