[RFC] in BI integration docs, move from translators to map_asset_specs #24802
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
branch-name: literal-tag-set
branch-name: power-bi-asset-type-tag
branch-name: customize-map-asset-specs
schrockn
reviewed
Sep 26, 2024
|
|
||
| def get_dashboard_spec(self, data: PowerBIContentData) -> AssetSpec: | ||
| return super().get_dashboard_spec(data)._replace(owners=["my_team"]) | ||
| def customize_powerbi_asset(spec: AssetSpec) -> AssetSpec: |
schrockn
approved these changes
Sep 26, 2024
| # We prefix all dashboard asset keys with "powerbi" for organizational | ||
| # purposes | ||
| return super().get_dashboard_asset_key(data).with_prefix("powerbi") | ||
| return spec._replace(key=key, owners="my_team") |
There was a problem hiding this comment.
This is an interesting decision point where we leak the implementation detail that we inherit from NamedTuple in a heavy way. We probably can't change things at this point, but worth nothing that we are telling users to use _replace when the might expect dataclass or pydantic variants of object copies.
graphite-app
bot
requested review from
C00ldudeNoonan,
cmpadden and
PedramNavid
Graphite Automations"Label and add CE on all Docs" took an action on this PR • (09/28/24)3 reviewers were added to this PR based on Pedram Navid's automation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
How I Tested These Changes
Changelog
NOCHANGELOG