-
Notifications
You must be signed in to change notification settings - Fork 1.7k
[dagster-pipes, docs] apply ruff to docs_snippets #24935
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
[dagster-pipes, docs] apply ruff to docs_snippets #24935
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
6e48e07
to
bddf8f1
Compare
6e81958
to
5ea968a
Compare
Mostly the changes are harmless, but I've spotted a few docs with multiple pieces of the same code snippet where imports reordering affected the first import appearance. I'm not looking for a full review before before I fix these small issues. @cmpadden @PedramNavid what are your thoughts on this idea in general? |
@danielgafni I am generally in favor of enforcing the same style throughout the code base. So applying our main To be honest, I'm surprised this wasn't already happening. |
Yeah I decided to start with Pipes because it's my area of responsibility, but we probably want to extend this practice to all examples and docs at some point. |
@@ -0,0 +1,163 @@ | |||
--- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If possible, could you separate the new guide content from the ruff formatting of docs_snippets?
Summary & Motivation
This PR applies
ruff
todocs_snippets
for Dagster Pipes docs.This is done by adding a
examples/docs_snippets/docs_snippets/guides/dagster/dagster_pipes/ruff.toml
file extending the mainruff
config.How I Tested These Changes
Changelog
NOCHANGELOG