Skip to content

[docs] fix dagster-dbt tutorial #27859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 20, 2025
Merged

[docs] fix dagster-dbt tutorial #27859

merged 3 commits into from
Feb 20, 2025

Conversation

jjyeo
Copy link
Contributor

@jjyeo jjyeo commented Feb 14, 2025 •
edited
Loading

Summary & Motivation

How I Tested These Changes

Changelog

  • Change variable name dbt_project to jaffle_shop_project in code snippets
  • Add packaged_project_dir parameter to DbtProject - this parameter is automatically added by the dagster-dbt project scaffold command
  • Update downstream-assets.md and load-dbt-models.md

[docs] fix dagster-dbt tutorial
e33af3c 
- change variable name `dbt_project` to `jaffle_shop_project` in code snippets
- add `packaged_project_dir` parameter to `DbtProject` - this parameter is automatically added by the `dagster-dbt project scaffold` command
- update `downstream-assets.md` and `load-dbt-models.md`
@jjyeo jjyeo requested a review from neverett as a code owner February 14, 2025 14:06
@jjyeo
Copy link
Contributor Author

jjyeo commented Feb 14, 2025

Manual test result:

Screenshot 2025-02-14 at 10 09 20 PM

@garethbrickman garethbrickman self-requested a review February 19, 2025 22:52
garethbrickman
garethbrickman approved these changes Feb 19, 2025
View reviewed changes
Copy link
Contributor

@garethbrickman garethbrickman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for addressing these!

@garethbrickman
Copy link
Contributor

garethbrickman commented Feb 19, 2025 •
edited
Loading

@jjyeo The build tests detected a problem: could you please change dbt_project to be jaffle_shop_project in this line too:

dagster/examples/docs_snippets/docs_snippets/integrations/dbt/tutorial/downstream_assets/assets.py

Line 31 in e33af3c

@dbt_assets(manifest=dbt_project.manifest_path)

Then run make ruff locally just to be sure it's happy about everything and should be good to merge then!

@jjyeo
Copy link
Contributor Author

jjyeo commented Feb 20, 2025 •
edited
Loading

@garethbrickman Thanks for highlighting the issue. I have applied the changes and run make ruff locally. Could you please review it?
Screenshot 2025-02-20 at 5 50 45 PM

@garethbrickman garethbrickman merged commit 324b58e into dagster-io:master Feb 20, 2025
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garethbrickman garethbrickman garethbrickman approved these changes

@neverett neverett Awaiting requested review from neverett

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@jjyeo @garethbrickman