remove partition view on asset events for non-sda assets #28941
+22
−125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 2, 2025
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit b30e09b. |
prha
force-pushed
the
prha/ui_asset_events
branch
from
20b1a63 to
b0c4ffd
Compare
bengotow
approved these changes
Apr 3, 2025
prha
force-pushed
the
prha/ui_asset_events
branch
from
b0c4ffd to
b30e09b
Compare
prha
force-pushed
the
prha/ui_partition_keys
branch
from
4227fbc to
9d25a61
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
We have quite a bit of complicated front-end code to group recent asset events by partition. This code only gets exercised when we're viewing an asset page for an asset whose definition has been removed from the workspace.
I posit that this view is rarely used. The asset page itself is extremely buried - it doesn't show up in the assets view. You have to dig it out from a historical run view.
The by-partition implementation also needs to be qualified. This isn't fetching all events by partition. It's fetching the last 100 events and then grouping them by partition key IF there is even a partition key on the materializations to be grouped by.
If we actually want to support this view, we could probably implement it by creating some new, different resolvers. We could fetch all unique partitions for a given asset in storage, and then fetch the most recent materialization for each partition.
How I Tested These Changes
Before:
After:
Changelog
By partitiongrouping view for recent events for assets that do not have a definition in the workspace.