Fix regression when creating nested ConfigurableResource with pydantic >= v.2.5.0 #28949
+35
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benpankow
changed the title
This stack of pull requests is managed by Graphite. Learn more about stacking. |
benpankow
force-pushed
the
benpankow/fix-nested-partial-resource-pydantic-25
branch
from
ef474ab to
6e059f5
Compare
benpankow
commented
Apr 2, 2025
| @@ -834,7 +834,7 @@ def _is_annotated_as_resource_type(annotation: type, metadata: list[str]) -> boo | |||
| """Determines if a field in a structured config class is annotated as a resource type or not.""" | |||
| from dagster._config.pythonic_config.type_check_utils import safe_is_subclass | |||
|
|
|||
| if metadata and metadata[0] == "resource_dependency": | |||
| if metadata and any(m == "resource_dependency" for m in metadata): | |||
There was a problem hiding this comment.
union mode left_to_right ends up in this metadata list, bumping resource dependency to second
benpankow
force-pushed
the
benpankow/fix-nested-partial-resource-pydantic-25
branch
from
6e059f5 to
3f96973
Compare
Co-authored-by: HynekBlaha <[email protected]>
benpankow
force-pushed
the
benpankow/fix-nested-partial-resource-pydantic-25
branch
from
3f96973 to
9902d58
Compare
deepyaman
approved these changes
Apr 2, 2025
|
Thanks @HynekBlaha @benpankow ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Slight tweak of @HynekBlaha's contribution in #28836 - this version adjusts our Pydantic union behavior for resources to account for a change in Pydantic 2.5.0 which uses 'smart unions' (pydantic/pydantic-core#867). This smart union behavior attempted to initialize each member of the union using the input data, which called the constructor for
PartialResourcewith invalid inputs.This PR enforces left-to-right union evaluation, similar to what occurred pre-Pydantic 2.5.0.
Test Plan
Unit test introduced in #28836.
Changelog
Fixed an issue where using partial resources in Pydantic >= 2.5.0 could result in an unexpected keyword argument TypeError. (Thanks @HynekBlaha!)