Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use uuid for runID in test #28961

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

neilfulwiler
Copy link
Contributor

Summary & Motivation

instead of "nope" for a non-existent runID, just uses a UUID instead

How I Tested These Changes

unit tests

@neilfulwiler neilfulwiler requested a review from gibsondan April 3, 2025 03:50
Copy link
Member

@gibsondan gibsondan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to separately test the 'passed in an invalid UUID" case in some fashion?

Copy link
Contributor Author

well i don't think we really can here because there's no such thing in this repo right? only specific backends might have some prescriptions around it (which is why I thought about doing this differently but this just seemed the most straightforward)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants