[dg] Add asset checks to dg list defs

[OwenKephart]

Summary & Motivation

Now we can pass info about asset checks through list defs

How I Tested These Changes

Also added an asset check to our unit tests

Changelog

dg list defs now includes infomation about asset checks.

[OwenKephart]

• [BUILD-880] Switch from dg scaffold project to dg init #29063
• [dg] Add asset checks to dg list defs #29016 👈 (View in Graphite)
• [dg] Use whitelist_for_serdes for DgDefinitionMetadata #29015
• [dg] Rework dg list defs output #28989
• [dg] Rename internal objects #28987
• [dg] Refactor PackageEntry types #28953 : 1 other dependent PR (#28954 )
• [dg] LibraryObject -> PackageEntry #28952
• master

This stack of pull requests is managed by Graphite. Learn more about stacking.

[schrockn]

can you post screenshot as test plan.

also a snapshot test would be good

[schrockn]

"can you post screenshot as test plan.

also a snapshot test would be good"

updated

[graphite-app]

The JSON test expectations appear to be missing the type field for each object. In the updated output format, each definition should include a field indicating whether it's an asset, job, schedule, etc., but these type fields have been removed from the test expectations. The actual output likely still includes these type identifiers, which would cause the tests to fail when comparing expected vs. actual output.

Suggested change

	│ │ │ my_schedule │ @daily │ │
	│ │ └─────────────┴───────────────┘ │
	│ Sensor │ ┏━━━━━━━━━━━┓ │
	│ │ ┃ Name ┃ │
	│ │ ┡━━━━━━━━━━━┩ │
	│ │ │ my_sensor │ │
	│ │ └───────────┘ │
	└──────────┴───────────────────────────────────────────────────────┘
	""").strip()
	_EXPECTED_DEFS_JSON = textwrap.dedent("""
	[
	{
	"type": "asset",
	"key": "my_asset_1",
	"group": "default",
	"deps": [],
	"kinds": [],
	"group": "default",
	"description": null,
	"automation_condition": null
	},
	{
	"type": "asset",
	"key": "my_asset_2",
	"group": "default",
	"deps": [],
	"kinds": [],
	"group": "default",
	"description": null,
	"automation_condition": null
	},
	{
	"type": "job",
	"name": "my_job"
	},
	{
	"type": "schedule",
	"name": "my_schedule",
	"cron_schedule": "@daily"
	},
	{
	"type": "sensor",
	"name": "my_sensor"
	}
	│ │ │ my_schedule │ @daily │ │
	│ │ └─────────────┴───────────────┘ │
	│ Sensor │ ┏━━━━━━━━━━━┓ │
	│ │ ┃ Name ┃ │
	│ │ ┡━━━━━━━━━━━┩ │
	│ │ │ my_sensor │ │
	│ │ └───────────┘ │
	└──────────┴───────────────────────────────────────────────────────┘
	""").strip()
	_EXPECTED_DEFS_JSON = textwrap.dedent("""
	[
	{
	"key": "my_asset_1",
	"deps": [],
	"kinds": [],
	"group": "default",
	"description": null,
	"automation_condition": null,
	"type": "asset"
	},
	{
	"key": "my_asset_2",
	"deps": [],
	"kinds": [],
	"group": "default",
	"description": null,
	"automation_condition": null,
	"type": "asset"
	},
	{
	"name": "my_job",
	"type": "job"
	},
	{
	"name": "my_schedule",
	"cron_schedule": "@daily",
	"type": "schedule"
	},
	{
	"name": "my_sensor",
	"type": "sensor"
	}

Spotted by Diamond

Is this helpful? React 👍 or 👎 to let us know.

[github-actions]

Deploy preview for dagster-docs ready!

Preview available at https://dagster-docs-803wnv7up-elementl.vercel.app
https://04-04-dg-add-asset-checks-to-dg-list-defs.archive.dagster-docs.io

Direct link to changed pages:

[OwenKephart]

Merge activity

• Apr 7, 12:34 PM EDT: A user started a stack merge that includes this pull request via Graphite.
• Apr 7, 12:51 PM EDT: Graphite rebased this pull request as part of a merge.
• Apr 7, 12:52 PM EDT: A user merged this pull request with Graphite.