[ui] Marketplace: Extract code examples in build script #29028
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit cbd22b0. |
hellendag
force-pushed
the
dish/integrations-code-example
branch
from
b84f4fd to
2fda052
Compare
hellendag
force-pushed
the
dish/build-904-dg-in-app
branch
from
917f332 to
7936528
Compare
hellendag
changed the base branch from
dish/build-904-dg-in-app
to
graphite-base/29028
hellendag
force-pushed
the
dish/integrations-code-example
branch
from
2fda052 to
cbd22b0
Compare
hellendag
force-pushed
the
graphite-base/29028
branch
from
7936528 to
cbcfed6
Compare
salazarm
reviewed
Apr 8, 2025
Comment on lines
+16
to
+17
| const CODE_EXAMPLE_PATH_REGEX = | ||
| /<(?:(?:CodeExample)|(?:CliInvocationExample))\s+[^>]*path=["']([^"']+)["'][^>]*language=["']([^"']+)["'][^>]*>/g; |
There was a problem hiding this comment.
Cribbed directly from docs code. 😅 When we unify this, at least it can just be scary living in one place.
salazarm
approved these changes
Apr 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Extract code snippets for generating integration docs.
How I Tested These Changes
yarn generate-integration-docs, verify that code is extracted correctly.