Skip to content

[dg] Eliminate 'component' in 'dg scaffold component' in dg docs as it is no longer valid #29118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 9, 2025

Conversation

schrockn
Copy link
Member

@schrockn schrockn commented Apr 8, 2025

Summary & Motivation

dg scaffold component no longer a command so changing it in the docs

How I Tested These Changes

Read

Changelog

NOCHANGELOG

Copy link
Member Author

schrockn commented Apr 8, 2025

@schrockn schrockn requested a review from hellendag April 8, 2025 20:59
@schrockn schrockn marked this pull request as ready for review April 8, 2025 20:59
Copy link
Member Author

@schrockn schrockn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hellendag how do i run prettier these days? Don't see it in the Makefile..

Copy link
Member

You can run yarn lint from the dg-docs-components directory, and it will run prettier. The dg stuff isn't currently included in the dagster-ui Makefile.

@schrockn schrockn force-pushed the schrockn/dg-scaffold-not-component branch from bce769a to 1555506 Compare April 8, 2025 22:51
@schrockn schrockn force-pushed the schrockn/dg-scaffold-not-component branch from 1555506 to e1cdebb Compare April 8, 2025 22:51
## Summary & Motivation

Update documentation to no longer refer to `dg scaffold component`

## How I Tested These Changes

Read

## Changelog

NOCHANGELOG
@schrockn schrockn requested a review from neverett as a code owner April 9, 2025 07:29
Copy link
Member Author

schrockn commented Apr 9, 2025

Merge activity

  • Apr 9, 4:44 AM EDT: A user started a stack merge that includes this pull request via Graphite.
  • Apr 9, 4:44 AM EDT: A user merged this pull request with Graphite.

@schrockn schrockn merged commit 5149910 into master Apr 9, 2025
7 checks passed
@schrockn schrockn deleted the schrockn/dg-scaffold-not-component branch April 9, 2025 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants