[dg] Make init command work with a dirname arg (BUILD-893) (BUILD-919) #29121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
smackesey
changed the title
smackesey
force-pushed
the
sean/dg/init-improvements
branch
from
2a73b54 to
3ed5e46
Compare
|
Deploy preview for dagster-docs ready! Preview available at https://dagster-docs-klce2t26w-elementl.vercel.app Direct link to changed pages: |
schrockn
reviewed
Apr 8, 2025
| dg init | ||
| Scaffold a new project in a new directory `<project_name>`. Prompts for `<project_name>`. | ||
| dg init . | ||
| Scaffold a new project in the CWD. |
There was a problem hiding this comment.
assume project name is taken from the name of the last component of the CWD?
There was a problem hiding this comment.
yes, will add to the description
schrockn
reviewed
Apr 8, 2025
smackesey
force-pushed
the
sean/dg/init-improvements
branch
from
3ed5e46 to
63b613b
Compare
Prefer follow-up |
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>
smackesey
added a commit
that referenced
this pull request
Apr 9, 2025
#29121) Change the `dg init` command in a few ways: - a `DIRNAME` argument is added - `--workspace-name` option is removed, replaced by `--workspace` flag - `DIRNAME` may be set to `.` to create (either workspace or project) in the current directory - default workspace prompt is now (`.`) Examples: - `dg init`: creates a project, prompts for project name - `dg init .`: scaffold a new project in the CWD - `dg init helloworld`: scaffold a new project in new dir `helloworld` - `dg init -workspace dagster-workspace`: scaffold a new workspace in new dir `dagster-workspace`, prompt for project name - `dg init --workspace .`: scaffold a new workspace in the CWD, prompt for project anme - `dg init --workspace --project-name helloworld .`: scaffold a new workspace in the CWD, create project named helloworld Modified init unit tests. The arguments/options of the `dg init` command have changed. You may pass `.` as an argument to initialize a project/workspace in the CWD. See `dg init --help` for more details. --------- Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Change the
dg initcommand in a few ways:DIRNAMEargument is added--workspace-nameoption is removed, replaced by--workspaceflagDIRNAMEmay be set to.to create (either workspace or project) in the current directory.)Examples:
dg init: creates a project, prompts for project namedg init .: scaffold a new project in the CWDdg init helloworld: scaffold a new project in new dirhelloworlddg init -workspace dagster-workspace: scaffold a new workspace in new dirdagster-workspace, prompt for project namedg init --workspace .: scaffold a new workspace in the CWD, prompt for project anmedg init --workspace --project-name helloworld .: scaffold a new workspace in the CWD, create project named helloworldHow I Tested These Changes
Modified init unit tests.
Changelog
The arguments/options of the
dg initcommand have changed. You may pass.as an argument to initialize a project/workspace in the CWD. Seedg init --helpfor more details.