[dg] Serialize component type info with code location, add GQL to power in-app docs #29167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
hellendag
approved these changes
Apr 10, 2025
| snaps = [get_package_entry_snap(key, obj) for key, obj in library_objects.items()] | ||
|
|
||
| components_json = json.dumps(json_for_all_components(snaps)) | ||
| print(components_json) |
benpankow
requested review from
smackesey,
gibsondan,
OwenKephart and
alangenfeld
and removed request for
gibsondan
benpankow
force-pushed
the
benpankow/gql-for-component-docs
branch
from
d766bfd to
4194250
Compare
|
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit 823a7ad. |
benpankow
force-pushed
the
benpankow/gql-for-component-docs
branch
from
4194250 to
328ad7e
Compare
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
python_modules/libraries/dagster-shared/dagster_shared/serdes/objects/package_entry.py
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Packages up component type JSON into the repository metadata of
load_defs, which can be accessed via GraphQL through the newlocationDocsJsonquery, which returns contents identical to the generated JSON which powersdg docs serve.