[perf] Share cache manager and add global cache for useAllAssets
#29179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit b57bf66. |
share cache manager share cache manager share cache manager share cache manager share cache manager
salazarm
force-pushed
the
salazarm/assets-perf
branch
from
b2050eb to
b57bf66
Compare
|
included in #29151 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Currently when there are multiple
useAllAssetshooks on the page they each end up handling indexeddb separately because they create separate cache managers. To fix this makegetCacheManagerthe only way to obtain one so that we reuse them and don't pull from indexeddb multiple times.Secondly add a global in memory cache to make sure we're not fetching more than once and not fetching too often. This is a stop-gap for now, long term we're going to get rid of this logic and fold everything into a generalized WorkspaceContext abstraction.
How I Tested These Changes
Use the app and everything works. Foregoing complicated testing for now since we will be folding this into the WorkspaceContext soon.