Skip to content

[Job graph] Include respository from pipeline selector in filtering #29191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 10, 2025

Conversation

salazarm
Copy link
Contributor

@salazarm salazarm commented Apr 10, 2025

Summary & Motivation

as titled

How I Tested These Changes

Logged into an organization where job names are not unique across deployments and saw that we correctly filtered assets to the right job by including the repository location and name.

@salazarm salazarm merged commit b3019c4 into master Apr 10, 2025
6 of 7 checks passed
@salazarm salazarm deleted the salazarm/fix-pipeline-selector-filter branch April 10, 2025 20:43
salazarm added a commit that referenced this pull request Apr 10, 2025
…29191)

## Summary & Motivation
as titled

## How I Tested These Changes

Logged into an organization where job names are not unique across
deployments and saw that we correctly filtered assets to the right job
by including the repository location and name.
Copy link

Deploy preview for dagit-core-storybook ready!

✅ Preview
https://dagit-core-storybook-4lnpeiq2a-elementl.vercel.app
https://salazarm-fix-pipeline-selector-filter.core-storybook.dagster-docs.io

Built with commit 78a4db0.
This pull request is being automatically deployed with vercel-action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants