[1/n][Asset Health] Add descriptions to health summary card #29256
Conversation
salazarm
changed the title
|
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit ee16d57. |
| <Body> | ||
| {numberFormatter.format(metadata.numWarningChecks)}/ | ||
| {numberFormatter.format(metadata.totalNumChecks)}{' '} | ||
| <Link to={assetDetailsPathForKey(assetKey, {view: 'checks'})}> |
There was a problem hiding this comment.
3 checks warning feels a bit odd but I guess technically correct!
| {numberFormatter.format(metadata.numWarningChecks)}/ | ||
| {numberFormatter.format(metadata.totalNumChecks)}{' '} | ||
| <Link to={assetDetailsPathForKey(assetKey, {view: 'checks'})}> | ||
| check | ||
| {ifPlural(metadata.totalNumChecks, '', 's')} | ||
| </Link>{' '} |
There was a problem hiding this comment.
feels vaguely like a checkStatus(metadata.numWarningChecks, metadata.totalNumChecks, 'warning') style helper could make this more readable, hard to see what is changing between all these cases
Probably not worth changing though
| ...AssetHealthCheckDegradedMetaFragment | ||
| ...AssetHealthCheckWarningMetaFragment | ||
| ...AssetHealthCheckUnknownMetaFragment | ||
| } |
There was a problem hiding this comment.
Is this stuff heavy? Was sort of imagining we'd fetch this on-hover but maybe it's not that big of a lift to pull the partition counts :-o 🎉
Summary & Motivation
How I Tested These Changes