[1/n]Remove conditional selection syntax flag gating in asset graph. #29258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit 730e4cf. |
salazarm
changed the title
bengotow
approved these changes
Apr 15, 2025
| viewType, | ||
| kindFilter, | ||
| groupsFilter, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
The feature flag is now always enabled and the ability to turn it off to be disabled. What's left is removing all of the conditional logic. There is a lot of it so I'm going to do it over multiple PRs. This is part 1 and removes the selection syntax from the asset graph (and another spot or two).
How I Tested These Changes
Just ran local host cloud for this one