[3/n][Observe UI] Add lineage tab #29267
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salazarm
changed the base branch from
master
to
salazarm/remove-selection-syntax-flag-1
|
Deploy preview for dagit-storybook ready! ✅ Preview Built with commit bb40e02. |
|
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit bb40e02. |
bengotow
approved these changes
Apr 15, 2025
Comment on lines
+711
to
+720
| <Tooltip content={isFullScreen ? 'Collapse' : 'Expand'}> | ||
| <Button | ||
| icon={ | ||
| <Icon | ||
| name={isFullScreen ? 'collapse_fullscreen' : 'expand_fullscreen'} | ||
| /> | ||
| } | ||
| onClick={toggleFullScreen} | ||
| /> | ||
| </Tooltip> |
There was a problem hiding this comment.
Could see wrapping this into a shared button so that we're consistent about adding the tooltip
js_modules/dagster-ui/packages/ui-core/src/assets/AssetCatalogLineage.tsx
Outdated
Show resolved
Hide resolved
js_modules/dagster-ui/packages/ui-core/src/assets/AssetCatalogTableV2.tsx
Outdated
Show resolved
Hide resolved
Base automatically changed from
salazarm/remove-selection-syntax-flag-1
to
master
April 15, 2025 15:01
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
This is behind the new observe UI feature flag. Adds the lineage tab
How I Tested These Changes
Screen.Recording.2025-04-14.at.5.08.39.PM.mov