[4/n] Support status in selection syntax #29289
Merged
+1,323
−816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salazarm
requested review from
bengotow,
benpankow,
OwenKephart and
clairelin135
|
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit e427f2f. |
bengotow
approved these changes
Apr 15, 2025
salazarm
force-pushed
the
salazarm/status-selection-syntax
branch
from
2b1ece0 to
dbef2e2
Compare
salazarm
force-pushed
the
salazarm/status-selection-syntax
branch
from
0c77e58 to
b148b99
Compare
OwenKephart
previously requested changes
Apr 15, 2025
python_modules/dagster/dagster/_core/definitions/asset_selection.py
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Adds support for status filtering in the selection syntax, gated by the new observe UIs feature flag.
Screen.Recording.2025-04-15.at.11.10.31.AM.mov
How I Tested These Changes
I owe a bunch of jest tests here but want to land this for dogfooding and will circle back with tests early next week.