[ui] Configurable "faceted" asset graph node designs #29307
+820
−94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 15, 2025 16:41
bengotow
changed the title
|
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit 87884e1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Linear: https://linear.app/dagster-labs/issue/OPER-1793/configurable-asset-graph-node-designs-prototype
Figma: https://www.figma.com/design/wXU4we6PavPVZt5dHZNQkY/Dagster-Observe---2025?node-id=1014-814&p=f&t=BY6WnhP5GaXjOz7F-0
This PR adds a new feature flag which enables faceted asset node rendering. In this new rendering style, you can choose exactly what bits of information you'd like to see on the asset graph, and data is presented in a more uniform way. All the nodes are the same size, and most facets are rendered in a
[key] [value]style within the node box.After this merges, I plan to follow-up with:
statusbar which will use the new asset health data (subject to a separate feature flag)One noteworthy / non-flagged change in this PR is that layout updates that do not result in a change in the number of edges, groups or nodes do NOT re-center the graph. This allows the user to change their displayed facets without losing their place in the graph.
Sidenote: Yesterday I mentioned I was trying to dynamically "tweak" the graph layouts to change node heights without re-running the layout algorithm. I was 1) unable to do this because external asset nodes are still tiny and do not scale, and scaling was creating odd spaces around them and 2) not seeing changes to asset height impact the placement of nodes in most cases anyway.
How I Tested These Changes
Tested feature flag on and off on both the asset graph and the asset lineage view, and also zoomed out to test minimal rendering.
Changelog
[ui] A new feature flag allows you to customize the appearance of assets on the asset graph by enabling and disabling individual facets.