[Catalogv2] Add favorites support #29317
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salazarm
requested review from
bengotow,
jamiedemaria,
anuthebananu and
clairelin135
salazarm
commented
Apr 16, 2025
Comment on lines
-242
to
-426
| </div> | ||
| </Row> | ||
| ); | ||
| } | ||
| return wrapper(<AssetRow asset={item} />); | ||
| })} | ||
| </Inner> | ||
| </Container> | ||
| ); | ||
| }, | ||
| ); | ||
|
|
||
| const StatusHeader = React.memo( | ||
| ({ | ||
| status, | ||
| open, | ||
| count, | ||
| onToggle, | ||
| }: { | ||
| status: AssetHealthStatusString; | ||
| open: boolean; | ||
| count: number; | ||
| onToggle: () => void; | ||
| }) => { | ||
| const {iconName, iconColor, text} = STATUS_INFO[status]; | ||
| return ( | ||
| <StatusHeaderContainer | ||
| flex={{direction: 'row', alignItems: 'center', gap: 4}} | ||
| onClick={onToggle} | ||
| > | ||
| <Icon name={iconName} color={iconColor} /> | ||
| <SubtitleSmall> | ||
| {text} ({numberFormatter.format(count)}) | ||
| </SubtitleSmall> | ||
| <Icon | ||
| name="arrow_drop_down" | ||
| style={{transform: open ? 'rotate(0deg)' : 'rotate(-90deg)'}} | ||
| color={Colors.textLight()} | ||
| /> | ||
| </StatusHeaderContainer> | ||
| ); | ||
| }, | ||
| ); | ||
|
|
||
| const StatusHeaderContainer = styled(Box)` | ||
| background-color: ${Colors.backgroundLight()}; | ||
| &:hover { | ||
| background-color: ${Colors.backgroundLightHover()}; | ||
| } | ||
| border-radius: 4px; | ||
| padding: 6px 24px; | ||
| `; | ||
|
|
||
| const AssetRow = React.memo(({asset}: {asset: AssetHealthFragment}) => { | ||
| const linkUrl = assetDetailsPathForKey({path: asset.assetKey.path}); | ||
|
|
||
| return ( | ||
| <RowWrapper to={linkUrl}> | ||
| <Box flex={{direction: 'row', alignItems: 'center', justifyContent: 'space-between'}}> | ||
| <Box flex={{direction: 'row', gap: 4, alignItems: 'center'}}> | ||
| <AssetIconWrapper> | ||
| <Icon name="asset" /> | ||
| </AssetIconWrapper> | ||
| {asset.assetKey.path.join(' / ')} | ||
| </Box> | ||
| {/* Prevent clicks on the trend from propoagating to the row and triggering the link */} | ||
| <div | ||
| onClick={(e) => { | ||
| e.stopPropagation(); | ||
| e.preventDefault(); | ||
| }} | ||
| className="test" | ||
| > | ||
| <AssetRecentUpdatesTrend asset={asset} /> | ||
| </div> | ||
| </Box> | ||
| </RowWrapper> | ||
| ); | ||
| }); | ||
|
|
||
| type AssetWithDefinition = AssetTableFragment & { | ||
| definition: NonNullable<AssetTableFragment['definition']>; | ||
| }; | ||
| const AssetIconWrapper = styled.div``; | ||
|
|
||
| const RowWrapper = styled(Link)` | ||
| color: ${Colors.textLight()}; | ||
| cursor: pointer; | ||
| :hover { | ||
| &, | ||
| ${AssetIconWrapper} ${IconWrapper} { | ||
| color: ${Colors.textDefault()}; | ||
| text-decoration: none; | ||
| } | ||
| ${AssetIconWrapper} ${IconWrapper} { | ||
| background: ${Colors.textDefault()}; | ||
| text-decoration: none; | ||
| } | ||
| } | ||
| `; |
There was a problem hiding this comment.
I move all of this to a new file for easier testing
|
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit d6e8274. |
| @@ -195,6 +188,8 @@ const Table = React.memo( | |||
| [assets], | |||
| ); | |||
|
|
|||
| // console.log({groupedByStatus, loading}); | |||
anuthebananu
approved these changes
Apr 16, 2025
…alazarm/new-catalog-page
jamiedemaria
pushed a commit
that referenced
this pull request
Apr 18, 2025
## Summary & Motivation Similar to what we do [here](https://github.com/dagster-io/dagster/blob/08aa439c5a52d3c24ff6e3e1856e2172f26bca8d/js_modules/dagster-ui/packages/ui-core/src/assets/AssetsCatalogTable.tsx#L220) and [here](https://github.com/dagster-io/dagster/blob/08aa439c5a52d3c24ff6e3e1856e2172f26bca8d/js_modules/dagster-ui/packages/ui-core/src/assets/AssetsGlobalGraphRoot.tsx#L65). Basically since this is in OSS we use that hook to signal whether or not we're currently in the favorites view and so should use the favorited assets. ## How I Tested These Changes jest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Similar to what we do here and here. Basically since this is in OSS we use that hook to signal whether or not we're currently in the favorites view and so should use the favorited assets.
How I Tested These Changes
jest