Skip to content

[Catalog V2] Fix lineage zoom + Add state for hiding/showing nodes outside of selection #29318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
salazarm merged 3 commits into from
Apr 16, 2025
Merged

[Catalog V2] Fix lineage zoom + Add state for hiding/showing nodes outside of selection #29318

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c09f77c
fix lineage
salazarm Apr 16, 2025
4700364
fix import
salazarm Apr 16, 2025
5d423a1
Merge branch 'master' into salazarm/catalog-v2-add-graph-controls
salazarm Apr 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 19 additions & 1 deletion js_modules/dagster-ui/packages/ui-core/src/assets/AssetCatalogAssetGraph.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import {AssetGraphExplorer} from '../asset-graph/AssetGraphExplorer';
import {AssetGraphViewType} from '../asset-graph/Utils';
import {AssetLocation} from '../asset-graph/useFindAssetLocation';
import {useOpenInNewTab} from '../hooks/useOpenInNewTab';
import {useStateWithStorage} from '../hooks/useStateWithStorage';
import {ExplorerPath} from '../pipelines/PipelinePathUtils';
import {workspacePathFromAddress} from '../workspace/workspacePath';

Expand Down Expand Up @@ -46,7 +47,23 @@ export const AssetCatalogAssetGraph = React.memo(
[history, openInNewTab],
);

const fetchOptions = React.useMemo(() => ({loading: false}), []);
const [hideEdgesToNodesOutsideQuery, setHideEdgesToNodesOutsideQuery] = useStateWithStorage(
'hideEdgesToNodesOutsideQuery',
(json) => {
if (json === 'false' || json === false) {
return false;
}
return true;
},
);

const fetchOptions = React.useMemo(
() => ({
loading: false,
hideEdgesToNodesOutsideQuery,
}),
[hideEdgesToNodesOutsideQuery],
);

const lineageOptions = React.useMemo(
() => ({preferAssetRendering: true, explodeComposites: true}),
Expand All @@ -73,6 +90,7 @@ export const AssetCatalogAssetGraph = React.memo(
viewType={AssetGraphViewType.CATALOG}
isFullScreen={isFullScreen}
toggleFullScreen={toggleFullScreen}
setHideEdgesToNodesOutsideQuery={setHideEdgesToNodesOutsideQuery}
/>
);
},
Expand Down
25 changes: 22 additions & 3 deletions js_modules/dagster-ui/packages/ui-core/src/assets/AssetCatalogTableV2.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,8 +148,16 @@ export const AssetsCatalogTableV2Impl = React.memo(
groupedByStatus,
]);

const extraStyles =
Copy link
Contributor

@anuthebananu anuthebananu Apr 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are these the css changes that fixed the zoom issue? Is AssetCatalogTableV2 used under the hood by the lineage graph then?

Copy link
Contributor Author

@salazarm salazarm Apr 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes this CSS fixes the zoom issue. The underlying component only knows about the current view because we pass a ViewType.CATALOG prop and its only used to avoid rendering a second selection syntax input

selectedTab === 'lineage'
? {
gridTemplateColumns: 'minmax(500px, 1fr)',
display: 'grid',
gridTemplateRows: 'repeat(2, auto) minmax(0, 1fr)',
}
: {};
return (
<Box flex={{direction: 'column'}} style={{height: '100%', minHeight: 600}}>
<Box flex={{direction: 'column'}} style={{height: '100%', minHeight: 600, ...extraStyles}}>
<Box
flex={{direction: 'row', alignItems: 'center', gap: 8}}
padding={{vertical: 12, horizontal: 24}}
Expand Down Expand Up @@ -200,7 +208,13 @@ const Table = React.memo(
);

return (
<div style={{display: 'grid', gridTemplateRows: 'minmax(0, 1fr)', height: '100%'}}>
<div
style={{
display: 'grid',
gridTemplateRows: 'minmax(0, 1fr)',
height: '100%',
}}
>
<div
// style={{
// display: 'grid',
Expand All @@ -209,7 +223,12 @@ const Table = React.memo(
// }}
>
<div
style={{display: 'grid', gridTemplateRows: 'auto minmax(500px, 1fr)', height: '100%'}}
style={{
display: 'grid',
gridTemplateRows: 'auto minmax(500px, 1fr)',
height: '100%',
gridTemplateColumns: 'minmax(500px, 1fr)',
}}
>
<Box
flex={{direction: 'row', alignItems: 'center', justifyContent: 'space-between'}}
Expand Down