gql resolvers for asset freshness state and internal freshness policy #29319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
anuthebananu
changed the title
anuthebananu
changed the title
|
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit aff2bd2. |
anuthebananu
requested review from
jamiedemaria,
salazarm,
dpeng817 and
OwenKephart
salazarm
reviewed
Apr 16, 2025
| @@ -279,6 +283,8 @@ class GrapheneAssetNode(graphene.ObjectType): | |||
| description = graphene.String() | |||
| freshnessInfo = graphene.Field(GrapheneAssetFreshnessInfo) | |||
| freshnessPolicy = graphene.Field(GrapheneFreshnessPolicy) | |||
| freshnessState = graphene.Field(GrapheneFreshnessStateRecord) | |||
There was a problem hiding this comment.
Should this be part of assetHealth ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Adds two resolvers on
GrapheneAssetNode-freshnessStateandinternalFreshnessPolicyfreshnessStateis gated to be non-op in OSS since it relies on cloud daemon machinery.How I Tested These Changes
unit tests / bk.
internalFreshnessPolicyhas tests in this PR since it's fetched directly from the asset node snapshotfreshnessStaterelies on daemon machinery in cloud, tests will be in a PR in the cloud repoChangelog