Component style tweaks for #32795
Component style tweaks for #32795
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
This PR is being reviewed by Cursor Bugbot
Details
Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
js_modules/dagster-ui/packages/ui-core/src/assets/catalog/AssetSelectionSummaryListItemV2.tsx
Outdated
Show resolved
Hide resolved
|
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit ae36a0a. |
js_modules/dagster-ui/packages/ui-core/src/assets/catalog/AssetsGroupedViewV2.tsx
Outdated
Show resolved
Hide resolved
js_modules/dagster-ui/packages/ui-core/src/assets/catalog/AssetsGroupedViewV2.tsx
Outdated
Show resolved
Hide resolved
js_modules/dagster-ui/packages/ui-core/src/assets/catalog/AssetsGroupedViewV2.tsx
Outdated
Show resolved
Hide resolved
js_modules/dagster-ui/packages/ui-core/src/assets/catalog/AssetsGroupedViewV2.tsx
Outdated
Show resolved
Hide resolved
js_modules/dagster-ui/packages/ui-core/src/assets/catalog/AssetSelectionSummaryListItemV2.tsx
Outdated
Show resolved
Hide resolved
js_modules/dagster-ui/packages/ui-core/src/assets/catalog/AssetsGroupedViewV2.tsx
Outdated
Show resolved
Hide resolved
js_modules/dagster-ui/packages/ui-core/src/assets/catalog/AssetsGroupedViewV2.tsx
Outdated
Show resolved
Hide resolved
js_modules/dagster-ui/packages/ui-core/src/assets/catalog/AssetsGroupedViewV2.tsx
Outdated
Show resolved
Hide resolved
js_modules/dagster-ui/packages/ui-core/src/assets/catalog/AssetSelectionSummaryListItemV2.tsx
Outdated
Show resolved
Hide resolved
hellendag
left a comment
hellendag
left a comment
There was a problem hiding this comment.
Is it correct that a couple of files were removed from this PR? Are they in a different PR now?
js_modules/dagster-ui/packages/ui-core/src/assets/catalog/AssetSelectionSummaryTile.tsx
Outdated
Show resolved
Hide resolved
js_modules/dagster-ui/packages/ui-core/src/assets/catalog/AssetSelectionSummaryTile.tsx
Show resolved
Hide resolved
Yeah. I realized that I wasn't even using those components anymore so I just removed them completely |
braunjj
force-pushed
the
josh/component-style-tweaks-for-cloud-catalog-root-redesign
branch
from
4feebcd to
2a686b9
Compare
There was a problem hiding this comment.
This is the final PR Bugbot will review for you during this billing cycle
Your free Bugbot reviews will reset on December 16
Details
Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
js_modules/dagster-ui/packages/ui-core/src/assets/catalog/AssetSelectionSummaryTile.tsx
Show resolved
Hide resolved
braunjj
force-pushed
the
josh/component-style-tweaks-for-cloud-catalog-root-redesign
branch
from
2a686b9 to
76a453e
Compare
hellendag
left a comment
hellendag
left a comment
There was a problem hiding this comment.
One comment inline for singular/plural, otherwise lgtm.
js_modules/dagster-ui/packages/ui-core/src/assets/catalog/AssetSelectionSummaryTile.tsx
Show resolved
Hide resolved
js_modules/dagster-ui/packages/ui-core/src/assets/catalog/AssetSelectionSummaryTile.tsx
Outdated
Show resolved
Hide resolved
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
js_modules/dagster-ui/packages/ui-core/src/assets/catalog/AssetSelectionSummaryTile.tsx
Outdated
Show resolved
Hide resolved
…tSelectionSummaryTile.tsx Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>
braunjj
force-pushed
the
josh/component-style-tweaks-for-cloud-catalog-root-redesign
branch
from
b6f620f to
ae36a0a
Compare
braunjj
deleted the
josh/component-style-tweaks-for-cloud-catalog-root-redesign
branch
Summary & Motivation
Modifies a few components in the Catalog to support the experimental catalog homepage refresh in Cloud.
Note
Asset selection tiles now show a formatted asset count when health status isn’t present; tile min-heights removed and font sizes reduced (including search input).
assetCountwhenstatusJsxis absent, usingnumberFormatter.statusJsxoptional; passassetCountfromAssetSelectionSummaryTile.minHeight: TILE_HEIGHTfrom tileBoxstyles..assetCountfont size to12px.SearchInputfont size from18pxto16px.Written by Cursor Bugbot for commit ae36a0a. This will update automatically on new commits. Configure here.