[dg] Update dg plus deploy refresh-defs-state command to handle subprocesses
#32851
+274
−129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
OwenKephart
force-pushed
the
11-18-_dg_update_dg_plus_deploy_refresh-defs-state_command_to_handle_subprocesses
branch
from
1d6ede1 to
3f77f9e
Compare
OwenKephart
force-pushed
the
11-18-_dg_update_dg_plus_deploy_refresh-defs-state_command_to_handle_subprocesses
branch
from
3f77f9e to
b20ddf9
Compare
OwenKephart
changed the base branch from
graphite-base/32851
to
11-20-_dg_add_--instance-ref_arg_to_refresh-defs-state
|
Deploy preview for dagster-docs ready! Preview available at https://dagster-docs-a76ev410z-elementl.vercel.app Direct link to changed pages: |
OwenKephart
force-pushed
the
11-18-_dg_update_dg_plus_deploy_refresh-defs-state_command_to_handle_subprocesses
branch
from
b20ddf9 to
707a52c
Compare
OwenKephart
force-pushed
the
11-20-_dg_add_--instance-ref_arg_to_refresh-defs-state
branch
from
4d5a804 to
cee07c4
Compare
OwenKephart
changed the base branch from
11-20-_dg_add_--instance-ref_arg_to_refresh-defs-state
to
graphite-base/32851
OwenKephart
force-pushed
the
graphite-base/32851
branch
from
cee07c4 to
fbe63d1
Compare
OwenKephart
force-pushed
the
11-18-_dg_update_dg_plus_deploy_refresh-defs-state_command_to_handle_subprocesses
branch
from
707a52c to
6edd4e4
Compare
OwenKephart
force-pushed
the
11-18-_dg_update_dg_plus_deploy_refresh-defs-state_command_to_handle_subprocesses
branch
from
6edd4e4 to
0938685
Compare
smackesey
approved these changes
Nov 21, 2025
Collaborator
smackesey
left a comment
smackesey
left a comment
There was a problem hiding this comment.
I'm vaguely uncomfortable with the "serialized instance as a comms channel for this specific information" hack but it seems like we can always change it later if we come up with a "cleaner" way to handle this stuff under the hood that doesn't involve a full gRPC server.
If it gets the job done!
OwenKephart
force-pushed
the
11-18-_dg_update_dg_plus_deploy_refresh-defs-state_command_to_handle_subprocesses
branch
from
0938685 to
5251ffe
Compare
OwenKephart
changed the base branch from
graphite-base/32851
to
11-17-_dg_add_support_for_gitlab_in_configure_workflow
OwenKephart
force-pushed
the
11-18-_dg_update_dg_plus_deploy_refresh-defs-state_command_to_handle_subprocesses
branch
from
5251ffe to
e0fa419
Compare
OwenKephart
force-pushed
the
11-17-_dg_add_support_for_gitlab_in_configure_workflow
branch
from
bf76707 to
5e04f13
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
This makes it so
dg plus deploy refresh-defs-statecan handle workspaces in addition to projects. previously we assumed we were executing in the same python environment as the main dg command, but this isn't always the case. Now, we create an InstanceRef that has access to our prod DefsStateStorage. We can then serialize this reference and pass it to the subprocess, which then invokesdg utils refresh-defs-statein the project's python env. This results in the instance in the main process being mutated, which we can then read from at the end to get the updated defs state info.How I Tested These Changes
Changelog