[ui] Improvements to AI Summary UI#32966
Conversation
|
Deploy preview for dagit-storybook ready! ✅ Preview Built with commit a8882bc. |
|
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit a8882bc. |
bengotow
force-pushed
the
begotow/ai-summary-feedback
branch
3 times, most recently
from
35d579a to
719102d
Compare
|
|
||
| export const RunAssetCheckTags = (props: {run: RunFragment}) => { | ||
| export const RunAssetCheckTags = (props: { | ||
| run: Pick<RunFragment, 'id' | 'pipelineName' | 'assetCheckSelection'>; |
There was a problem hiding this comment.
It's a little annoying to me that this has to make reference to RunFragment at all instead of just listing the props it wants. 😆 Though the Pick is certainly better than requiring the entire fragment.
bengotow
force-pushed
the
begotow/ai-summary-feedback
branch
from
719102d to
6bf2ec4
Compare
- The split panel no longer has an unused 2px divider space on the right hand side if the second panel is unmounted. - The AI summary menu item appears on the run details page in the top right menu. - The types for RunAssetTags and RunAssetCheckTags have been scoped down so they’re easier to re-use. [INTERNAL_BRANCH=begotow/ai-summary-feedback]
bengotow
force-pushed
the
begotow/ai-summary-feedback
branch
from
6bf2ec4 to
a8882bc
Compare
|
Really don't know what's up with the buildkite issues, going to rebase both PRs again and push them both and we'll see if it's happy this time. Probably a couple hundred build minutes trying to get both green checks here 😂 |
2 participants
Related: https://github.com/dagster-io/internal/pull/19444
The split panel no longer has an unused 2px divider space on the right hand side if the second panel is unmounted.
The AI summary menu item appears on the run details page in the top right menu.
The types for RunAssetTags and RunAssetCheckTags have been scoped down so they’re easier to re-use.
[INTERNAL_BRANCH=bengotow/ai-summary-feedback]