[asset health] add latest run id to partitioned asset materialization health metadata#32970
Merged
Merged
Conversation
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Contributor
|
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit 3d96775. |
jamiedemaria
changed the title
jamiedemaria
marked this pull request as ready for review
December 4, 2025 16:17
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
jamiedemaria
force-pushed
the
jamie/health-partition-meta-has-run-id
branch
from
December 4, 2025 16:46
b9ddab2 to
235533f
Compare
jamiedemaria
commented
Dec 4, 2025
jamiedemaria
force-pushed
the
jamie/health-partition-meta-has-run-id
branch
from
December 5, 2025 15:22
24cddb6 to
ff21a7d
Compare
jamiedemaria
commented
Dec 5, 2025
jamiedemaria
force-pushed
the
jamie/health-partition-meta-has-run-id
branch
from
December 5, 2025 15:28
ff21a7d to
4d2852b
Compare
gibsondan
previously requested changes
Dec 8, 2025
gibsondan
left a comment
gibsondan
left a comment
There was a problem hiding this comment.
question for you about sourcing from streamline instead if that's not a big lift
jamiedemaria
force-pushed
the
jamie/health-partition-meta-has-run-id
branch
2 times, most recently
from
December 12, 2025 17:06
74917a8 to
0d367d4
Compare
jamiedemaria
force-pushed
the
jamie/health-partition-meta-has-run-id
branch
from
December 12, 2025 20:56
0d367d4 to
3d96775
Compare
Contributor
Author
|
see https://github.com/dagster-io/internal/pull/19535 and #33004 for the attr in streamline |
gibsondan
approved these changes
Dec 15, 2025
gibsondan
left a comment
gibsondan
left a comment
There was a problem hiding this comment.
I don't think there are any push safety issues with making the new field nullable? If there weren't any before?
Contributor
Author
|
yeah the FE already handles the field as if it could be null afaict |
Contributor
Author
Merge activity
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have the latest run id available on the health object, so include it in the corresponding graphene objects to use in the FE
tests in https://app.graphite.com/github/pr/dagster-io/internal/19452/[DAGSTER_BRANCH%3Djamie%2Fhealth-partition-meta-has-run-id]