[ui] TS native preview#32990
Merged
Merged
Conversation
Contributor
|
Deploy preview for dagit-storybook ready! ✅ Preview Built with commit 9400d99. |
Contributor
|
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit 9400d99. |
hellendag
marked this pull request as ready for review
December 5, 2025 20:50
hellendag
commented
Dec 5, 2025
| * Merges result data for queries of the same type. | ||
| * See mocking.test.ts for example usage | ||
| */ | ||
| export function mergeMockQueries<T extends Record<string, any>>( |
Contributor
Author
There was a problem hiding this comment.
This wasn't being used anywhere in OSS, and was the only place raising TS errors.
Contributor
Author
Merge activity
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the TypeScript native preview to a few JS projects in
dagster, along with atsgoscript to run it.https://devblogs.microsoft.com/typescript/progress-on-typescript-7-december-2025/
This will let us start trying it out a bit before everyone switches to use it, using it in builds, etc.
I had to iron out a couple of issues. Will comment inline.
Test Plan
For each project with
tsgoadded, runyarn tsgo.make tsgofromdagster-ui.