Make the failure button on the runs page show more information about the failure event #33262
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit 4e7aad0. |
gibsondan
force-pushed
the
showrunfailureevent
branch
from
6a3756f to
c48d8cc
Compare
…the failure event > Insert changelog entry or delete this section.
gibsondan
force-pushed
the
showrunfailureevent
branch
from
c48d8cc to
4e7aad0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, you had to filter the event log to type:RUN_FAILURE to get the reason the run failed. Now, the "Failure" button up top is clickable and shows that information if it has been set from the event log scan that the run page does.
How I Tested These Changes
Load a run with a run failure with a stack trace and without, with and without a step failure, with a step failure with and without a stack trace
Changelog
[ui] Failed runs now display more information about why the run failed when clicking on the Failure status on the run page.