Fix issue when using asset decorates in pyright strict mode #33275
+13
−13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Fixes #33251
Resolves Pyright strict mode "Type of X is partially unknown" errors when using
@asset,@multi_asset, and@graph_assetdecorators. This enables developers to use Pyright's strict type checking mode with Dagster asset decorators without encountering type warnings.Root Cause
The asset decorators had three missing type annotations that caused Pyright in strict mode to infer "Unknown" types:
Anytype annotation on**kwargsparametersAutomationCondition(should beAutomationCondition[AssetKey])PartitionsDefinition(should bePartitionsDefinition[str])Changes
Updated type annotations in
/python_modules/dagster/dagster/_core/definitions/decorators/asset_decorator.py:assetdecoratorAnytype annotation to**kwargsin both overloads and implementationAutomationConditiontoAutomationCondition[AssetKey]PartitionsDefinitiontoPartitionsDefinition[str]multi_assetdecoratorPartitionsDefinitiontoPartitionsDefinition[str]graph_assetdecoratorAnytype annotation to**kwargsAutomationConditiontoAutomationCondition[AssetKey]PartitionsDefinitiontoPartitionsDefinition[str]How I Tested These Changes
Changelog
@asset,@multi_asset, and@graph_assetdecorators. The decorators now have complete type annotations including proper generic type parameters forAutomationCondition[AssetKey]andPartitionsDefinition[str]