[dg] removes hidden dg mcp command in preparation for official server#33697
Conversation
Greptile SummaryThis PR removes the hidden
Confidence Score: 5/5
|
| Filename | Overview |
|---|---|
| python_modules/libraries/dagster-dg-cli/dagster_dg_cli/cli/init.py | Removes the import and registration of mcp_group from the dg CLI command set — clean two-line removal. |
| python_modules/libraries/dagster-dg-cli/dagster_dg_cli/cli/mcp_server.py | Deleted entirely — contained the mcp serve and mcp configure CLI subcommands. Clean removal with no dangling references. |
| python_modules/libraries/dagster-dg-cli/dagster_dg_cli/mcp/server.py | Deleted entirely — contained the FastMCP server with all dg-backed tools. Clean removal. |
| python_modules/libraries/dagster-dg-cli/dagster_dg_cli_tests/cli_tests/mcp_tests/test_mcp_serve.py | Test file deleted alongside the implementation, but the mcp_tests/__init__.py package marker was not deleted — minor leftover. |
| python_modules/libraries/dagster-dg-cli/pyproject.toml | Removes mcp from the ai optional-dependency group — consistent with the deleted server code. |
| python_modules/libraries/dagster-dg-cli/tox.ini | Removes the mcp dep entry and the dedicated mcp: tox environment; also drops the --ignore=mcp_tests flag from the general command now that the test directory is (mostly) gone. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart TD
DG[dg CLI] --> SCAFFOLD[scaffold]
DG --> DEV[dev]
DG --> PLUS[plus]
DG --> LIST[list]
DG --> UTILS[utils]
DG --> LAUNCH[launch]
DG --> CHECK[check]
DG --> API[api]
MCP_REMOVED["~~mcp~~ (removed)"]:::removed
MCP_REMOVED -.->|"serve"| SERVE["~~serve~~"]:::removed
MCP_REMOVED -.->|"configure"| CONFIGURE["~~configure (claude-desktop / cursor / vscode / claude-code)~~"]:::removed
classDef removed fill:#fdd,stroke:#f00,color:#900,text-decoration:line-through
Comments Outside Diff (1)
-
python_modules/libraries/dagster-dg-cli/dagster_dg_cli_tests/cli_tests/mcp_tests/__init__.py, line 1 (link)Leftover empty
__init__.pyafter test file deletionThe
test_mcp_serve.pyfile was deleted, but the containingmcp_tests/__init__.py(and themcp_tests/directory itself) was not cleaned up. Thetox.inigeneralcommand no longer ignores this directory, so pytest will traverse into it — which is harmless since there are no test files, but the orphaned directory and__init__.pyare dead weight. Consider deleting the entiredagster_dg_cli_tests/cli_tests/mcp_tests/directory.
Reviews (1): Last reviewed commit: "[dg] removes hidden `dg mcp` command in ..." | Re-trigger Greptile
…er (dagster-io#33697) ## Summary & Motivation Removes the half-baked `dg mcp` server as our general guidance is to use dagster-io/skills wrapping the `dg api`.
Summary & Motivation
Removes the half-baked
dg mcpserver as our general guidance is to use dagster-io/skills wrapping thedg api.