Skip to content

chore: improve dagster maintenance path #33884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lphuc2250gma wants to merge 1 commit into
base: master
Choose a base branch
from
Open

chore: improve dagster maintenance path #33884

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions examples/deploy_ecs/tests/test_deploy.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,11 +24,11 @@ def docker_context(test_id, monkeypatch, tmpdir):

# Use ecs --local-simulation
# https://docs.docker.com/cloud/ecs-integration/#local-simulation
subprocess.call(["docker", "context", "create", "ecs", "--local-simulation", test_id])
subprocess.run(["docker", "context", "create", "ecs", "--local-simulation", test_id], check=True)

yield test_id

subprocess.call(["docker", "context", "rm", test_id])
subprocess.run(["docker", "context", "rm", test_id], check=True)

@greptile-apps greptile-apps Bot May 27, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 check=True in fixture teardown can mask real failures

Adding check=True to the cleanup call means a non-zero exit from docker context rm raises CalledProcessError during teardown, converting a normal test failure (or xfail) into a fixture ERROR. If the context can't be removed — e.g., because a prior test run left state behind and the test_id fixture still collides, or because the ECS local-simulation container is still running when teardown fires — the exception surfaces instead of (or alongside) the real test outcome. Teardown code should generally suppress or log errors rather than propagate them, so that cleanup failures don't obscure the actual failure being investigated.



@pytest.fixture
Expand Down