fix(deps): cap grpcio below 1.82.0 to avoid protobuf 7.x incompatibility#33979
Closed
0xliam wants to merge 2 commits into
Closed
fix(deps): cap grpcio below 1.82.0 to avoid protobuf 7.x incompatibility#339790xliam wants to merge 2 commits into
0xliam wants to merge 2 commits into
Conversation
Contributor
…7.x incompatibility
Author
|
Force pushed as I forgot to update uv.lock - this should now be ready for review. |
|
@0xliam Thank you to bring up this PR. I wonder if you are merging to latest 1.13 version of dagster for this patch and may not recently backfill to previous version. |
Author
I'd be happy to backport this if needed - I'll await review from the maintainers to confirm how they'd like me to proceed. |
Author
|
Closing as this is now resolved by a249c55 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
The latest version of
grpcio/grpcio-health-checking(18.2.0 - released a few hours ago) ships with a dependency ofprotobuf==7.35.1, however Dagster pinsprotobuf>=4,<7.After running
uvx create-dagster@latestanddg dev, the following error is received:Additionally, when running the Python test suite, tests were failing prior to this change:
Test Plan
Running the test suite no longer fails with these errors.