fix: internal DAG configuration data handling issue

[yottahmd]

Summary by CodeRabbit

• Bug Fixes

  • Improved YAML configuration rebuild reliability to properly preserve field values and maintain configuration integrity during DAG updates.
  • Enhanced environment variable handling in configuration rebuilds to ensure dotenv values are correctly applied when reloading from YAML.

• Tests

  • Added comprehensive test coverage for YAML configuration rebuild functionality.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

📝 Walkthrough

Walkthrough

The rebuildDAGFromYAML function is refactored to copy only JSON-excluded fields from a freshly loaded DAG into the original DAG object, returning the same pointer instead of a new instance. Comprehensive unit tests are added to verify field preservation and pointer identity.

Changes

Cohort / File(s)	Summary
DAG Rebuild Logic internal/cmd/helper.go	Modified rebuildDAGFromYAML to copy only JSON-excluded fields (Env, Params, ParamsJSON, SMTP, SSH, RegistryAuths) into the original DAG object; returns same pointer with defaults initialized in place rather than on a fresh copy; updates environment-building logic documentation.
DAG Rebuild Tests internal/cmd/helper_test.go	Added unit tests covering field preservation (Queue, WorkerSelector, MaxActiveRuns, MaxActiveSteps, LogDir, Tags, Location), pointer identity verification, empty YAML handling with default Queue value, and environment variable incorporation from YAML.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~22 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 40.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately identifies the main change—fixing internal DAG configuration data handling in the rebuild function.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.10%. Comparing base (ce036b8) to head (c74d286).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1583   +/-   ##
=======================================
  Coverage   65.09%   65.10%           
=======================================
  Files         258      258           
  Lines       28645    28649    +4     
=======================================
+ Hits        18647    18651    +4     
  Misses       8327     8327           
  Partials     1671     1671           

Files with missing lines	Coverage Δ
internal/cmd/helper.go	82.14% <100.00%> (+11.30%)	⬆️

... and 3 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce036b8...c74d286. Read the comment docs.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.