Conversation
|
No actionable comments were generated in the recent review. 🎉 📝 WalkthroughWalkthroughThis PR introduces configurable HTTP access logging with three modes—all requests, non-public endpoints only (excluding health checks), or no logging. It enables users to reduce log noise from automated health checks like Kubernetes probes while maintaining visibility into actual traffic. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
If possible set log levels also, e.g. info, debug, error, warning, etc if set to error or warning, the logging will reduce drastically |
|
@ghansham Yes, I agree. We can add that later. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1695 +/- ##
==========================================
- Coverage 70.20% 70.14% -0.07%
==========================================
Files 369 369
Lines 40878 40887 +9
==========================================
- Hits 28699 28680 -19
- Misses 9906 9932 +26
- Partials 2273 2275 +2
... and 14 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Resolves #1694
Summary by CodeRabbit