Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added zoom in zoom out for DAGs. #774 #899

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

kriyanshii
Copy link
Contributor

added zoom in zoom out in mermaid.tsx for navigating through huge DAGs.

Copy link

codecov bot commented Mar 31, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.52%. Comparing base (6c1a2d9) to head (637eeac).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #899      +/-   ##
==========================================
+ Coverage   55.48%   55.52%   +0.03%     
==========================================
  Files          75       75              
  Lines        8240     8240              
==========================================
+ Hits         4572     4575       +3     
+ Misses       3281     3279       -2     
+ Partials      387      386       -1     

see 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c1a2d9...637eeac. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@yottahmd
Copy link
Collaborator

@kriyanshii Looking great! I tried building the UI locally, but ran into the following error. It works fine without the changes in tsconfig.json. I'm wondering if we can revert that file if the changes aren't necessary. What do you think?

% yarn build
yarn run v1.22.22
$ webpack --config webpack.prod.js
assets by status 2.05 MiB [cached] 3 assets
./src/index.tsx 39 bytes [built] [code generated]

ERROR in ./src/index.tsx
Module build failed (from ./node_modules/ts-loader/index.js):
Error: TypeScript emitted no output for /dev/dagu/ui/src/index.tsx.
    at makeSourceMapAndFinish (/dev/dagu/ui/node_modules/ts-loader/dist/index.js:55:18)
    at successLoader (/dev/dagu/ui/node_modules/ts-loader/dist/index.js:42:5)
    at Object.loader (/dev/dagu/ui/node_modules/ts-loader/dist/index.js:23:5)

webpack 5.97.1 compiled with 1 error in 11708 ms
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

@yottahmd
Copy link
Collaborator

It's working very nicely! One thing I observed is that the icon-area moves as the graph is scrolled horizontally. Would it be possible to anchor them to the top-right corner?
image

@kriyanshii
Copy link
Contributor Author

yeah. tried doing it. will submit a pr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants