Skip to content

Merge WinUI3 extensions #507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
tajbender wants to merge 7 commits into
base: master
Choose a base branch
from
Draft

Merge WinUI3 extensions #507

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
879e6b6
Add temporary ReSharper configs
tajbender Dec 28, 2024
27d4763
Merge pull request #1 from dahall/master
tajbender Feb 9, 2025
58f7342
Delete .idea/.idea.Vanara/.idea/vcs.xml
tajbender Feb 13, 2025
d376ec4
Merge pull request #3 from electrifier/Remove-ReSharper-config-files
tajbender Feb 13, 2025
52e0284
Merge branch 'dahall:master' into WinUI.Extensions
tajbender Feb 13, 2025
bfa232a
Update Vanara.WinUI.Extensions.csproj
tajbender Mar 11, 2025
85579ba
Merge branch 'master' into WinUI.Extensions
tajbender Mar 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions .idea/.idea.Vanara/.idea/.gitignore
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 4 additions & 0 deletions .idea/.idea.Vanara/.idea/encodings.xml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 8 additions & 0 deletions .idea/.idea.Vanara/.idea/indexLayout.xml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

14 changes: 8 additions & 6 deletions WinUI.Extensions/Vanara.WinUI.Extensions.csproj
View file
Open in desktop
Copy link
Contributor Author

@tajbender tajbender Feb 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll have to delete

  • TargetFrameworks net5.0-windows

Copy link
Contributor Author

@tajbender tajbender Mar 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, we don't have to. Minimum should be net5

Copy link
Contributor Author

@tajbender tajbender Mar 11, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

↪️ See official Requirements

Copy link
Contributor Author

@tajbender tajbender Mar 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dahall any comment?

Copy link
Owner

@dahall dahall Mar 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a number of assemblies that don't support all the same .NET versions as the rest of the project. .NET 5-9 and maybe Core 3.1 would be fine.

Copy link
Contributor Author

@tajbender tajbender Mar 14, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for clarifying 👍🏻

According #507 (comment), net6 is an Requirement for WinUI 3...

I really don't have any knowledge whether the code would run with WinUI 2. But, since Requirements for WinUI 2 are at least Windows 10, imho it makes no sense to even try to downgrade.

Original file line number Diff line number Diff line change
Expand Up @@ -3,29 +3,31 @@
<PropertyGroup>
<Description>Extension methods and conversions from Vanara P/Invoke types and methods to UWP and WinUI types and methods.</Description>
<AssemblyTitle>$(AssemblyName)</AssemblyTitle>
<TargetFrameworks>net5.0-windows;net6.0;net7.0;net8.0-windows</TargetFrameworks>
<TargetFrameworks>$(TargetFrameworksNotStd)</TargetFrameworks>
<ImportWindowsDesktopTargets>true</ImportWindowsDesktopTargets>
<UseWPF>true</UseWPF>
<AssemblyName>Vanara.WinUI.Extensions</AssemblyName>
<PackageId>$(AssemblyName)</PackageId>
<PackageTags>pinvoke;vanara;net-extensions;interop;winui;uwp;windows platform</PackageTags>
<PackageReleaseNotes>Currently implements:

Classes
SystemFoundationExtensions
ExplorerBrowser

</PackageReleaseNotes>
<PackageReadmeFile>pkgreadme.md</PackageReadmeFile>
<GeneratePackageOnBuild>true</GeneratePackageOnBuild>
<Title>Vanara WinUI 3 Controls and Classes</Title>
<Authors>David Hall, tajbender</Authors>
<PackageLicenseUrl>https://github.com/dahall/vanara</PackageLicenseUrl>
</PropertyGroup>
<ItemGroup Condition=" '$(TargetFramework)' == 'net48' ">
<Reference Include="netstandard" />
</ItemGroup>
<ItemGroup>
<ProjectReference Include="..\PInvoke\Gdi32\Vanara.PInvoke.Gdi32.csproj" />
<ProjectReference Include="..\PInvoke\User32\Vanara.PInvoke.User32.csproj" />
<ProjectReference Include="..\Windows.Shell.Common\Vanara.Windows.Shell.Common.csproj" />
</ItemGroup>
<ItemGroup>
<PackageReference Include="System.Runtime.WindowsRuntime" Version="4.7.0" />
<PackageReference Include="System.Runtime.WindowsRuntime" Version="4.1.1" />
</ItemGroup>
</Project>
</Project>