Fix launch_server, to be able to use persistent_context and user_data_dir #398
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #253
When attempting to use
persistent_contextanduser_data_dirparameters inlaunch_server():These parameters are completely ignored - they are not read, parsed, or taken into account by the implementation.
Solution
According to playwright-core/src/browserServerImpl.ts, the underlying implementation supports passing
_userDataDirfor persistent contexts.This PR adds support for these parameters in
launch_server()to enable persistent context functionality when launching browser servers.