Handle cookies dict set to prevent AttributeError #91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use merge_cookies instead of individual set_cookie calls when handling dictionary cookies. This ensures: - Consistent behavior across all cookie types (dict, list, RequestsCookieJar) - Better handling of cookie merging and potential conflicts - Proper domain and path handling through merge_cookies function
rojoyin
changed the title
Session.get() to prevent AttributeError
rojoyin
changed the title
Session.get() to prevent AttributeError
rojoyin
changed the title
rojoyin
commented
Mar 12, 2025
| elif isinstance(cookies, list): | ||
| merge_cookies(self.cookies, list_to_cookiejar(cookies)) | ||
| elif isinstance(cookies, dict): | ||
| merge_cookies(self.cookies, cookiejar_from_dict(cookies)) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use merge_cookies instead of individual set_cookie calls when handling dictionary cookies. This ensures:
Open issue: #90