Add bulk close options#1024
Conversation
Can you remove this for now. The |
690596f to
da07975
Compare
Ok, done |
|
Oops referenced wrong issue. |
|
I did some cleanup/updates that incorporated these changes. There were a few different places that handled prompting the user with the save dialog. That has been consolidated. Also allows a user when selecting save all to abort if they cancel a save. Let me know what you think. |
|
Thanks for the cleanup and improvements! Consolidating the save dialog handling and adding the abort-on-cancel behavior for "Save All" makes sense — much cleaner approach. I'll go ahead and close my PR since these changes are now covered by your implementation. Appreciate you taking the time to review and refine this.
…---- Replied Message ----
| From | ***@***.***> |
| Date | 05/12/2026 07:37 |
| To | ***@***.***> |
| Cc | ***@***.***>***@***.***> |
| Subject | Re: [dail8859/NotepadNext] Add bulk close options (PR #1024) |
dail8859 left a comment (dail8859/NotepadNext#1024)
I did some cleanup/updates that incorporated these changes.
There were a few different places that handled prompting the user with the save dialog. That has been consolidated. Also allows a user when selecting save all to abort if they cancel a save. Let me know what you think.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
|
I hadn't merged in your commits yet, I just made the update to this PR to work on it. |
|
Merged now. Thanks for the pull request! |
|
Glad to see it merged! Thanks for the cleanup and improvements along the way — the consolidated save dialog handling and abort-on-cancel for "Save All" are nice touches. Appreciate you taking the time to review and refine it.
…---- Replied Message ----
| From | ***@***.***> |
| Date | 05/12/2026 09:14 |
| To | ***@***.***> |
| Cc | ***@***.***>、State ***@***.***> |
| Subject | Re: [dail8859/NotepadNext] Add bulk close options (PR #1024) |
dail8859 left a comment (dail8859/NotepadNext#1024)
Merged now. Thanks for the pull request!
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you modified the open/close state.Message ID: ***@***.***>
|

Summary
Screenshot
The multi-file unsaved changes dialog shows Discard All, Cancel, and Save All actions in one prompt.
Testing