Skip to content

Add bulk close options#1024

Merged
dail8859 merged 3 commits into
dail8859:masterfrom
dst1213:feature/save-discard-all-and-macos-singleapp
May 12, 2026
Merged

Add bulk close options#1024
dail8859 merged 3 commits into
dail8859:masterfrom
dst1213:feature/save-discard-all-and-macos-singleapp

Conversation

@dst1213
Copy link
Copy Markdown
Contributor

@dst1213 dst1213 commented Apr 28, 2026

Summary

  • Add a single confirmation dialog when closing multiple unsaved files, with Save All, Discard All, and Cancel options.
  • Keep the existing per-file Save / Discard / Cancel dialog for a single unsaved file.

Screenshot

The multi-file unsaved changes dialog shows Discard All, Cancel, and Save All actions in one prompt.

Testing

  • Not run locally after removing the SingleApplication patch; final diff is limited to the bulk close dialog behavior.

@dst1213
Copy link
Copy Markdown
Contributor Author

dst1213 commented Apr 28, 2026

image (1)

@dail8859
Copy link
Copy Markdown
Owner

Patch the pinned SingleApplication dependency to avoid QNativeIpcKey on Qt 6.6+, fixing macOS shm_open bad name startup failures.

Can you remove this for now. The SingleApplication has other known problems with >= Qt6.6 (which is why this app is still using Qt6.5) and these changes should be submitted to that project.

@dst1213 dst1213 force-pushed the feature/save-discard-all-and-macos-singleapp branch from 690596f to da07975 Compare April 29, 2026 14:43
@dst1213 dst1213 changed the title Add bulk close options and patch SingleApplication Add bulk close options Apr 29, 2026
@dst1213
Copy link
Copy Markdown
Contributor Author

dst1213 commented Apr 29, 2026

Patch the pinned SingleApplication dependency to avoid QNativeIpcKey on Qt 6.6+, fixing macOS shm_open bad name startup failures.

Can you remove this for now. The SingleApplication has other known problems with >= Qt6.6 (which is why this app is still using Qt6.5) and these changes should be submitted to that project.

Ok, done

@dail8859 dail8859 closed this in 408eaf6 Apr 29, 2026
@dail8859
Copy link
Copy Markdown
Owner

Oops referenced wrong issue.

@dail8859 dail8859 reopened this Apr 29, 2026
@dail8859
Copy link
Copy Markdown
Owner

I did some cleanup/updates that incorporated these changes.

There were a few different places that handled prompting the user with the save dialog. That has been consolidated. Also allows a user when selecting save all to abort if they cancel a save. Let me know what you think.

@dst1213
Copy link
Copy Markdown
Contributor Author

dst1213 commented May 12, 2026 via email

@dst1213 dst1213 closed this May 12, 2026
@dail8859
Copy link
Copy Markdown
Owner

I hadn't merged in your commits yet, I just made the update to this PR to work on it.

@dail8859 dail8859 reopened this May 12, 2026
@dail8859 dail8859 merged commit 0e03151 into dail8859:master May 12, 2026
23 checks passed
@dail8859
Copy link
Copy Markdown
Owner

Merged now. Thanks for the pull request!

@dst1213
Copy link
Copy Markdown
Contributor Author

dst1213 commented May 12, 2026 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants